Re: [PATCH 1/1] sched_ext: Add error logging for dsq creation failures

[Emil Tsalapatis]

Hi George,

(sorry for the formatting, my email client has decided not to indent the email)

________________________________________
From: George Guo <dongtai.guo@xxxxxxxxx>
Sent: Wednesday, January 7, 2026 1:28 AM
To: tj@xxxxxxxxxx; void@xxxxxxxxxxxxx; arighi@xxxxxxxxxx; changwoo@xxxxxxxxxx
Cc: sched-ext@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; George Guo
Subject: [PATCH 1/1] sched_ext: Add error logging for dsq creation failures

From: George Guo <guodongtai@xxxxxxxxxx>

Add scx_bpf_error() calls when scx_bpf_create_dsq() fails in multiple
schedulers to improve debuggability:

- scx_central.bpf.c: central_init()
- scx_flatcg.bpf.c: fcg_cgroup_init() and fcg_init()
- scx_qmap.bpf.c: qmap_init()
- scx_simple.bpf.c: simple_init()

Signed-off-by: George Guo <guodongtai@xxxxxxxxxx>
---

While the change looks correct, is there any benefit to it? 

- Failing to create a dsq will already cause init() to fail with the error code 
from the failed call. In scx_simple in particular, the  change adds no new 
info because the function amounts to a single scx_bpf_create_dsq() call.

- Regressions to scx_bpf_dsq_create() from kernel-side (as opposed to
BPF scheduler-side) changes will be caught by the selftests.

Not opposed to it, just curious what the advantages are.