Re: [PATCH v2 05/11] rust: macros: use `quote!` for `module!` macro
From: Gary Guo
Date: Wed Jan 07 2026 - 12:55:00 EST
On Wed, 7 Jan 2026 12:19:26 -0500
Tamir Duberstein <tamird@xxxxxxxxx> wrote:
> On Wed, Jan 7, 2026 at 11:59 AM Gary Guo <gary@xxxxxxxxxx> wrote:
> >
> > From: Gary Guo <gary@xxxxxxxxxxx>
> >
> > This has no behavioural change, but is good for maintainability. With
> > `quote!`, we're no longer using string templates, so we don't need to
> > quote " and {} inside the template anymore. Further more, editors can
> > now highlight the code template.
> >
> > This also improves the robustness as it eliminates the need for string
> > quoting and escaping.
> >
> > Co-developed-by: Benno Lossin <lossin@xxxxxxxxxx>
> > Signed-off-by: Benno Lossin <lossin@xxxxxxxxxx>
> > Signed-off-by: Gary Guo <gary@xxxxxxxxxxx>
>
> Are there significant changes here? You didn't pick up my tag.
There're changes related to added `params` which you probably already
noticed.
Best,
Gary