Re: [PATCH v8 05/18] liveupdate: luo_core: add user interface
From: Jason Gunthorpe
Date: Wed Jan 07 2026 - 13:27:19 EST
On Tue, Nov 25, 2025 at 11:58:35AM -0500, Pasha Tatashin wrote:
> +struct liveupdate_ioctl_create_session {
> + __u32 size;
> + __s32 fd;
> + __u8 name[LIVEUPDATE_SESSION_NAME_LENGTH];
> +};
IMHO I would use
__u32 name_len;
__u32 reserved;
__aligned_u64 name_uptr;
And then have the kernel copy_from_user() the name into kernel
memory. That way you avoid making LIVEUPDATE_SESSION_NAME_LENGTH into
strict ABI.
I have also been marking the output members with out_, so:
__s32 out_fd;
for example
Jason