Re: [PATCH] perf Documentation: Correct branch stack sampling call-stack option

[Namhyung Kim]

Hello,

On Wed, Jan 07, 2026 at 08:58:53AM +0800, Mi, Dapeng wrote:
> @Arnaldo, @Kim, @Ian
> 
> Kindly ping ... 

Sorry for the delay.

> 
> On 12/16/2025 9:39 AM, Dapeng Mi wrote:
> > The correct call-stack option for branch stack sampling should be "stack"
> > instead of "call_stack". Correct it.
> >
> > $perf record -e instructions -j call_stack -- sleep 1
> > unknown branch filter call_stack, check man page
> >
> >  Usage: perf record [<options>] [<command>]
> >     or: perf record [<options>] -- <command> [<options>]
> >
> >     -j, --branch-filter <branch filter mask>
> >                           branch stack filter modes
> >
> > Cc: stable@xxxxxxxxxxxxxxx
> > Fixes: 955f6def5590 ("perf record: Add remaining branch filters: "no_cycles", "no_flags" & "hw_index"")
> > Signed-off-by: Dapeng Mi <dapeng1.mi@xxxxxxxxxxxxxxx>

Reviewed-by: Namhyung Kim <namhyung@xxxxxxxxxx>

Thanks,
Namhyung

> > ---
> >  tools/perf/Documentation/perf-record.txt | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/Documentation/perf-record.txt b/tools/perf/Documentation/perf-record.txt
> > index e8b9aadbbfa5..3d19e77c9c53 100644
> > --- a/tools/perf/Documentation/perf-record.txt
> > +++ b/tools/perf/Documentation/perf-record.txt
> > @@ -454,7 +454,7 @@ following filters are defined:
> >  	- no_tx: only when the target is not in a hardware transaction
> >  	- abort_tx: only when the target is a hardware transaction abort
> >  	- cond: conditional branches
> > -	- call_stack: save call stack
> > +	- stack: save call stack
> >  	- no_flags: don't save branch flags e.g prediction, misprediction etc
> >  	- no_cycles: don't save branch cycles
> >  	- hw_index: save branch hardware index
> >
> > base-commit: cb015814f8b6eebcbb8e46e111d108892c5e6821