Re: [PATCH v2] pwm: tiehrpwm: Enable EHRPWM controller before setting configuration

[Gokul Praveen]

Hi Rafael,

On 08/01/26 01:17, Rafael V. Volkmer wrote:
> Hi Uwe, Gokul,
>
> Thanks for CC'ing me on this thread.
>
> On 07/01/26 15:21, Uwe Kleine-König wrote:
> > Hello,
> >
> > adding Rafael to Cc: who sent a patch series for this driver that I
> > didn't come around to review yet. Given that neither he nor me noticed
> > the problem addressed in this patch I wonder if it applies to all
> > hardware variants.
>
> I also didn't observe the issue described here in my testing: duty cycle and
> period changes always appeared to take effect as expected.
>
> My tests were done on an AM623 EVM.
>
> One possible explanation is that my test flow mostly exercised configuration
> while the PWM was already enabled/active, which could mask the effect of a
> put_sync/reset happening after configuration.

Yes, this is the reason why the configuration was taking effect for you 
, Rafael, as the PWM was already enabled when setting the configuration 
hence masking the effect of a put_sync/reset happening after configuration.

Best Regards
Gokul Praveen

> Regarding my pending patch series for this driver: it should not
> conflict this change, as it's largely preparatory refactoring for a
> follow-up series.
>
> Best regards,
> Rafael V. Volkmer