Re: [PATCH v10 5/5] arm64: dts: qcom: talos-evk: Add support for QCS615 talos evk board

[Konrad Dybcio]

On 1/8/26 8:36 AM, tessolveupstream@xxxxxxxxx wrote:
> 
> 
> On 04-01-2026 19:16, tessolveupstream@xxxxxxxxx wrote:
>>
>>
>> On 30-12-2025 20:21, Konrad Dybcio wrote:
>>> On 12/30/25 2:02 PM, Sudarshan Shetty wrote:
>>>> Add the device tree for the QCS615-based Talos EVK platform. The
>>>> platform is composed of a System-on-Module following the SMARC
>>>> standard, and a Carrier Board.
>>>>
>>>> The Carrier Board supports several display configurations, HDMI and
>>>> LVDS. Both configurations use the same base hardware, with the display
>>>> selection controlled by a DIP switch.
>>>
>>> [...]
>>>
>>>> +++ b/arch/arm64/boot/dts/qcom/talos-evk-lvds-auo,g133han01.dtso
>>>> @@ -0,0 +1,126 @@
>>>> +// SPDX-License-Identifier: BSD-3-Clause
>>>> +/*
>>>> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
>>>> + */
>>>> +/dts-v1/;
>>>> +/plugin/;
>>>> +
>>>> +#include <dt-bindings/gpio/gpio.h>
>>>> +
>>>> +&{/} {
>>>> +	backlight: backlight {
>>>> +		compatible = "gpio-backlight";
>>>> +		gpios = <&tlmm 59 GPIO_ACTIVE_HIGH>,
>>>> +			<&tlmm 115 GPIO_ACTIVE_HIGH>;
>>>> +		default-on;
>>>> +	};
>>>> +
>>>> +	hdmi_connector: hdmi-out {
>>>> +		status = "disabled";
>>>> +	};
>>>
>>> This should be a &label_reference
>>>
>>
>> Okay, will add it in the next patch.
> 
> I noticed that in several existing .dtso files, the root node is
> commonly referenced as &{/}. In your comment, you suggested using &label_reference. Could you please clarify which specific label or 
> node you would like me to update here.

&{/} must be used for root nodes in a .dtso (for it to compile). I meant
using a &label_reference for hdmi_connector

Konrad