Re: [PATCH v2 1/7] dt-bindings: backlight: qcom-wled: Document ovp values for PMI8994

[barnabas . czeman]

On 2026-01-08 09:54, Konrad Dybcio wrote:
> On 1/8/26 4:43 AM, Barnabás Czémán wrote:
> > Document ovp values supported by wled found in PMI8994.
> >
> > Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
>
> I reviewed a version of this that said PMI8950, which is very much
> not the same..
>
> Let me try and get some more docs to confirm or deny what you're
> saying..
I have sent it for the previous revision msm-4.4 contains the 
documentation.
https://lore.kernel.org/all/95f7c89fdf9b856f567a498cc56ecfa5@xxxxxxxxxxxxxx/T/#u
> Konrad
>
> > Signed-off-by: Barnabás Czémán <barnabas.czeman@xxxxxxxxxxxxxx>
> > ---
> >  .../bindings/leds/backlight/qcom-wled.yaml         | 22 
> > ++++++++++++++++++++--
> >  1 file changed, 20 insertions(+), 2 deletions(-)
> >
> > diff --git 
> > a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml 
> > b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml
> > index a8490781011d..19166186a1ff 100644
> > --- a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml
> > +++ b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml
> > @@ -98,8 +98,8 @@ properties:
> >      description: |
> >        Over-voltage protection limit. This property is for WLED4 only.
> >      $ref: /schemas/types.yaml#/definitions/uint32
> > -    enum: [ 18100, 19600, 29600, 31100 ]
> > -    default: 29600
> > +    minimum: 17800
> > +    maximum: 31100
> >
> >    qcom,num-strings:
> >      description: |
> > @@ -239,6 +239,24 @@ allOf:
> >            minimum: 0
> >            maximum: 4095
> >
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            const: qcom,pmi8994-wled
> > +
> > +    then:
> > +      properties:
> > +        qcom,ovp-millivolt:
> > +          enum: [ 17800, 19400, 29500, 31000 ]
> > +          default: 29500
> > +
> > +    else:
> > +      properties:
> > +        qcom,ovp-millivolt:
> > +          enum: [ 18100, 19600, 29600, 31100 ]
> > +          default: 29600
> > +
> >  required:
> >    - compatible
> >    - reg