Re: [PATCH v2 1/7] dt-bindings: backlight: qcom-wled: Document ovp values for PMI8994

From: barnabas . czeman

Date: Thu Jan 08 2026 - 06:32:23 EST


On 2026-01-08 10:22, Konrad Dybcio wrote:
On 1/8/26 10:17 AM, barnabas.czeman@xxxxxxxxxxxxxx wrote:
On 2026-01-08 09:54, Konrad Dybcio wrote:
On 1/8/26 4:43 AM, Barnabás Czémán wrote:
Document ovp values supported by wled found in PMI8994.

Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>

I reviewed a version of this that said PMI8950, which is very much
not the same..

Let me try and get some more docs to confirm or deny what you're
saying..
I have sent it for the previous revision msm-4.4 contains the documentation.
https://lore.kernel.org/all/95f7c89fdf9b856f567a498cc56ecfa5@xxxxxxxxxxxxxx/T/#u

Right, but I didn't send any reply acknowledging that.

On v1, my review tag meant "I concur this is the case for PMI8950"
Yes, sorry. Since they are pretty much same i have considered it is a
minor change i have only changed everything to pmi8994 because it
was introduced before pmi8950 at upstream. I will be more careful next time.

Because you carried it in v2, it appears as if I said "I concur this
is the case for PMI8994", which is not what I then said.

Konrad