Re: [PATCH v2 2/2] clk: renesas: rzv2h: Deassert reset on assert timeout
From: Geert Uytterhoeven
Date: Thu Jan 08 2026 - 09:00:16 EST
On Thu, 8 Jan 2026 at 13:34, Biju <biju.das.au@xxxxxxxxx> wrote:
> From: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
>
> If the assert() fails due to timeout error, set the reset register bit
> back to deasserted state. This change is needed especially for handling
> assert error in suspend() callback that expect the device to be in
> operational state in case of failure.
>
> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> ---
> v1->v2:
> * Added the variable "mon" in __rzv2h_cpg_assert() and used in
> readl_poll_timeout_atomic() instead of reusing "value".
> * Dropped the assert check in error path and simplified value using xor.
> * Added Rb tag from Geert.
Thanks, will queue in renesas-clk for v6.20.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds