Re: [PATCH v5 03/13] dmaengine: axi-dmac: use sg_nents_for_dma() helper

From: Nuno Sá
Date: Thu Jan 08 2026 - 09:09:05 EST


On Thu, 2026-01-08 at 11:50 +0100, Andy Shevchenko wrote:
> Instead of open coded variant let's use recently introduced helper.
>
> Reviewed-by: Bjorn Andersson <andersson@xxxxxxxxxx>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---

Reviewed-by: Nuno Sá <nuno.sa@xxxxxxxxxx>

>  drivers/dma/dma-axi-dmac.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c
> index 045e9b9a90df..f5caf75dc0e7 100644
> --- a/drivers/dma/dma-axi-dmac.c
> +++ b/drivers/dma/dma-axi-dmac.c
> @@ -677,10 +677,7 @@ static struct dma_async_tx_descriptor *axi_dmac_prep_slave_sg(
>   if (direction != chan->direction)
>   return NULL;
>  
> - num_sgs = 0;
> - for_each_sg(sgl, sg, sg_len, i)
> - num_sgs += DIV_ROUND_UP(sg_dma_len(sg), chan->max_length);
> -
> + num_sgs = sg_nents_for_dma(sgl, sg_len, chan->max_length);
>   desc = axi_dmac_alloc_desc(chan, num_sgs);
>   if (!desc)
>   return NULL;