Re: [PATCH] block: initialize auto integrity buffer opaque

[Caleb Sander Mateos]

On Thu, Jan 8, 2026 at 5:58 AM Christoph Hellwig <hch@xxxxxx> wrote:
>
> The subject sounds a little weird.  From looking at the commit
> message and the code change I'd expect it to be something like:
>
> block: zero auto integrity buffer when not fully occupied by PI tuple
>
> does that make sense?

Yes, that sounds fine. "opaque" is how the FS_IOC_GETLBMD_CAP ioctl
refers to the non-PI metadata, but I guess it's not widely used
terminology?

>
> > Switch the gfp_t variable to bool zero_buffer since it's only used to
> > compute the zero_buffer argument to bio_integrity_alloc_buf().
>
> Yeah, that also makes total sense now.  But maybe split it into a
> separate cleanup patch to not detract from the bug fix?

Sure.

Thanks,
Caleb