Re: [PATCH v1 2/2] vfio/nvgrace-gpu: register device memory for poison handling

From: Ankit Agrawal
Date: Thu Jan 08 2026 - 14:31:07 EST


>> +static inline
>> +struct nvgrace_gpu_pci_core_device *vma_to_nvdev(struct vm_area_struct *vma);
>
> Any reason not to define vma_to_nvdev() here directly, but later?

Actually since it uses nvgrace_gpu_vfio_pci_mmap_ops; which the compiler
complains to be undeclared if vma_to_nvdev is moved up.

>> +       ret = register_pfn_address_space(&region->pfn_address_space);
>> +
>> +       return ret;
>
> nit: I believe "ret" is unnecessary here.

Yes, I'll address that.