Re: [PATCH] media: verisilicon: AV1: Set IDR flag for intra_only frame type
From: Nicolas Dufresne
Date: Thu Jan 08 2026 - 14:47:13 EST
Le jeudi 08 janvier 2026 à 14:29 +0100, Benjamin Gaignard a écrit :
> Intra_only frame could be considered as a key frame so Instantaneous
> Decoding Refresh (IDR) flag must be set of the both case and not only
> for key frames.
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@xxxxxxxxxxxxx>
> Reported-by: Jianfeng Liu <liujianfeng1994@xxxxxxxxx>
> Fixes: 727a400686a2c ("media: verisilicon: Add Rockchip AV1 decoder")
Reviewed-by: Nicolas Dufresne <nicolas.dufresne@xxxxxxxxxxxxx>
> ---
> drivers/media/platform/verisilicon/rockchip_vpu981_hw_av1_dec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/verisilicon/rockchip_vpu981_hw_av1_dec.c b/drivers/media/platform/verisilicon/rockchip_vpu981_hw_av1_dec.c
> index 1605cfd55d36..3a8123bbe144 100644
> --- a/drivers/media/platform/verisilicon/rockchip_vpu981_hw_av1_dec.c
> +++ b/drivers/media/platform/verisilicon/rockchip_vpu981_hw_av1_dec.c
> @@ -2047,7 +2047,7 @@ static void rockchip_vpu981_av1_dec_set_parameters(struct hantro_ctx *ctx)
> !!(ctrls->frame->quantization.flags
> & V4L2_AV1_QUANTIZATION_FLAG_DELTA_Q_PRESENT));
>
> - hantro_reg_write(vpu, &av1_idr_pic_e, !ctrls->frame->frame_type);
> + hantro_reg_write(vpu, &av1_idr_pic_e, IS_INTRA(ctrls->frame->frame_type));
> hantro_reg_write(vpu, &av1_quant_base_qindex, ctrls->frame->quantization.base_q_idx);
> hantro_reg_write(vpu, &av1_bit_depth_y_minus8, ctx->bit_depth - 8);
> hantro_reg_write(vpu, &av1_bit_depth_c_minus8, ctx->bit_depth - 8);
Attachment:
signature.asc
Description: This is a digitally signed message part