Re: [PATCH 2/2] x86/virt/tdx: Print TDX module version during init

From: Dave Hansen
Date: Thu Jan 08 2026 - 15:49:57 EST


On 1/8/26 10:39, Verma, Vishal L wrote:
> ret = ret ?: get_tdx_sys_info_version(&sysinfo->version);
> +
> + pr_info("Module version: %u.%u.%02u\n",
> + sysinfo->version.major_version,
> + sysinfo->version.minor_version,
> + sysinfo->version.update_version);

This is wonky, but it's also fine.

If we can't even get the module version, we have pretty big problems on
our hands Seeing "Module version: 0.0.00" is a nice indication. It'll
almost certainly be followed by a bunch of other nasty messages, so one
wonky message before them will be a drop in the bucket.