Re: [PATCH v2 1/3] staging: rtl8723bs: fix firmware memory leak on error

From: Dan Carpenter
Date: Fri Jan 09 2026 - 01:15:02 EST


On Thu, Jan 08, 2026 at 10:16:09AM -0800, Samasth Norway Ananda wrote:
> After successfully calling request_firmware(), if the firmware size
> check fails or if kmemdup() fails, the code jumps to the exit label
> without calling release_firmware(), causing a memory leak. Call
> release_firmware() directly in each error path before jumping to cleanup
> label.
>
> Signed-off-by: Samasth Norway Ananda <samasth.norway.ananda@xxxxxxxxxx>

Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

regards,
dan carpenter