Re: [PATCH v1] arm64: defconfig: enable WCD937X codec driver as module
From: Ajay Kumar Nandam
Date: Fri Jan 09 2026 - 02:37:51 EST
On 1/8/2026 1:12 PM, Krzysztof Kozlowski wrote:
On 08/01/2026 08:41, Krzysztof Kozlowski wrote:
On 08/01/2026 08:34, Ajay Kumar Nandam wrote:
Enable the Qualcomm WCD937X SoundWire codec driver as a
loadable module in the arm64 defconfig. This is required for
audio support on platforms using the WCD937X codec over the
SoundWire interface.
Not a good reason. You wrote four lines of which all are redundant,
because you still did not prove we need to have support for WCD937x
Soundwire interface.
Ack, I will rework the commit message accordingly.
Signed-off-by: Ajay Kumar Nandam <ajay.nandam@xxxxxxxxxxxxxxxx>
---
Look incomplete.
https://lore.kernel.org/all/20240916052352.1819088-1-quic_mohs@xxxxxxxxxxx/
https://lore.kernel.org/all/20241010052646.2597418-1-quic_mohs@xxxxxxxxxxx/
https://lore.kernel.org/all/20241007082312.2136358-1-quic_mohs@xxxxxxxxxxx/
https://lore.kernel.org/all/?q=CONFIG_SND_SOC_WCD937X_SDW
But anyway, you did the same as all patches before, so it won't be
applied. There is really no point in sending the same three four times.
Nothing will change, no one will apply it, unless you finally fix the
address list.
You also Cc-ed here completely random addresses... E.g. why is this
relevant to Xilinx?
ack,
will resend an updated version with the correct maintainer and mailing
list CCs added using get_maintainer.pl for the relevant SoC.
Previously, I ran get_maintainer.pl on the arm64 defconfig instead of on
the SoC‑specific, which resulted in an incomplete and incorrect address
list. I will ensure this is done correctly going forward.
Thanks
Ajay kumar Nandam
And I already said all this so you could have build on previous feedback
instead of repeating exactly same two mistakes.
https://lore.kernel.org/all/638a44fc-c693-4270-8643-7cd75a3c6ba6@xxxxxxxxxx/
Best regards,
Krzysztof