Re: [PATCH v6 2/4] backlight: add max25014atg backlight

[Maud Spierings]

Do you have any comments about:

> +static void max25014_remove(struct i2c_client *cl)
> +{
> +	struct max25014 *maxim = i2c_get_clientdata(cl);
> +
> +	maxim->bl->props.brightness = 0;
> +	max25014_update_status(maxim->bl);
> +	gpiod_set_value_cansleep(maxim->enable, 0);
> +	regulator_disable(maxim->vin);
> +}

I'm feeling like the setting of the brightness + update status maybe 
should be a call to backlight_device_set_brightness() or maybe it 
shouldn't really be there at all?

Kind regards,
Maud