Re: [PATCH] dt-bindings: serial: sh-sci: Fold single-entry compatibles into enum

From: Geert Uytterhoeven
Date: Fri Jan 09 2026 - 08:34:22 EST


Hi Prabhakar,

On Fri, 9 Jan 2026 at 13:38, Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>
> Group single compatibles into enum.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>

Thanks for your patch!

> --- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml
> +++ b/Documentation/devicetree/bindings/serial/renesas,scif.yaml
> @@ -20,6 +20,8 @@ properties:
> - items:

I the "- items:" can be dropped, reducing indentation of the block
below.

> - enum:
> - renesas,scif-r7s9210 # RZ/A2
> + - renesas,scif-r9a07g044 # RZ/G2{L,LC}
> + - renesas,scif-r9a09g057 # RZ/V2H(P)

This block now indeed contains all single compatible values, but it
is still located in the middle of other multi-compatible entries.
What about making it the first block in the "oneOf:"?


For the contents:
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds