Re: [PATCH 1/2] arm64: dts: renesas: Use hyphen in node names

From: Krzysztof Kozlowski
Date: Fri Jan 09 2026 - 10:22:19 EST


On 09/01/2026 16:18, Geert Uytterhoeven wrote:
> Hi Krzysztof,
>
> On Tue, 23 Dec 2025 at 16:24, Krzysztof Kozlowski
> <krzysztof.kozlowski@xxxxxxxxxxxxxxxx> wrote:
>> DTS coding style prefers hyphens instead of underscores in the node
>> names. Change should be safe, because node names are not considered an
>> ABI.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
>
> Thanks for your patch!
>
>> arch/arm64/boot/dts/renesas/r8a77970-eagle.dts | 4 ++--
>> arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts | 4 ++--
>> arch/arm64/boot/dts/renesas/r8a77980-v3hsk.dts | 4 ++--
>> arch/arm64/boot/dts/renesas/salvator-common.dtsi | 4 ++--
>> arch/arm64/boot/dts/renesas/ulcb.dtsi | 2 +-
>> 5 files changed, 9 insertions(+), 9 deletions(-)
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
> Is there any specific reason you didn't fix the remaining ones?

These are coming from scripted sed, so probably my regex was incomplete.
But in few cases (not sure if here) I did not touch clock node names, if
they do not have clock-output-names, because it might break users.

>
> $ git grep -e '[a-zA-Z0-9-]*_[a-zA-Z0-9-]*@' HEAD --
> arch/arm64/boot/dts/renesas
> arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi:
> versaclock5: versaclock_som@6a {
> arch/arm64/boot/dts/renesas/condor-common.dtsi:
> cert_header_sa3@c0000 {
> arch/arm64/boot/dts/renesas/condor-common.dtsi:
> cert_header_sa6@180000 {
> arch/arm64/boot/dts/renesas/draak.dtsi:
> cert_header_sa6@180000 {
> arch/arm64/boot/dts/renesas/ebisu.dtsi:
> cert_header_sa6@180000 {
> arch/arm64/boot/dts/renesas/hihope-rev4.dtsi: cs2000: clk_multiplier@4f {
>
> No worries, will queue in renesas-devel for v6.20, with those fixed, too.
>
> Gr{oetje,eeting}s,
>
> Geert
>


Best regards,
Krzysztof