Re: [PATCH] mfd: qcom-pm8xxx: fix OF populate on driver rebind

[Lee Jones]

On Fri, 19 Dec 2025, Johan Hovold wrote:

> Since commit c6e126de43e7 ("of: Keep track of populated platform
> devices") child devices will not be created by of_platform_populate()
> if the devices had previously been deregistered individually so that the
> OF_POPULATED flag is still set in the corresponding OF nodes.
> 
> Switch to using of_platform_depopulate() instead of open coding so that
> the child devices are created if the driver is rebound.
> 
> Fixes: c6e126de43e7 ("of: Keep track of populated platform devices")
> Cc: stable@xxxxxxxxxxxxxxx	# 3.16
> Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>
> ---
>  drivers/mfd/qcom-pm8xxx.c | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/drivers/mfd/qcom-pm8xxx.c b/drivers/mfd/qcom-pm8xxx.c
> index 1149f7102a36..0cf374c015ce 100644
> --- a/drivers/mfd/qcom-pm8xxx.c
> +++ b/drivers/mfd/qcom-pm8xxx.c
> @@ -577,17 +577,11 @@ static int pm8xxx_probe(struct platform_device *pdev)
>  	return rc;
>  }
>  
> -static int pm8xxx_remove_child(struct device *dev, void *unused)
> -{
> -	platform_device_unregister(to_platform_device(dev));
> -	return 0;
> -}
> -
>  static void pm8xxx_remove(struct platform_device *pdev)
>  {
>  	struct pm_irq_chip *chip = platform_get_drvdata(pdev);
>  
> -	device_for_each_child(&pdev->dev, NULL, pm8xxx_remove_child);
> +	of_platform_depopulate(&pdev->dev);
>  	irq_domain_remove(chip->irqdomain);

Have you explored devm_of_platform_populate()?

-- 
Lee Jones [李琼斯]