Re: [PATCH] mfd: stpmic1: Attempt system shutdown twice in case PMIC is confused

Next message: Lee Jones: "Re: (subset) [PATCH] mfd: axp20x: AXP717: Add type-C CC registers"
Previous message: barnabas . czeman: "Re: [PATCH v2 2/7] backlight: qcom-wled: Support ovp values for PMI8994"
In reply to: Sean Nyekjaer: "Re: [PATCH] mfd: stpmic1: Attempt system shutdown twice in case PMIC is confused"
Next in thread: Lee Jones: "Re: [PATCH] mfd: stpmic1: Attempt system shutdown twice in case PMIC is confused"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

From: Marek Vasut

Date: Fri Jan 09 2026 - 10:47:10 EST

On 1/9/26 3:54 PM, Sean Nyekjaer wrote:

On Fri, Jan 09, 2026 at 05:12:09AM +0100, Marek Vasut wrote:

Attempt to shut down again, in case the first attempt failed.
The STPMIC1 might get confused and the first regmap_update_bits()
returns with -ETIMEDOUT / -110 . If that or similar transient
failure occurs, try to shut down again. If the second attempt
fails, there is some bigger problem, report it to user.

I don't think I have ever seen my devices fail to shutdown.
Have you ever seen the second call fail?

I have sporadically seen the first call fail with timeout, not the second one yet. If the second call fails, I think we have a real bad hardware problem.

Maybe these issues are hidden on devices which use SCMI too, so they never get properly fixed in the direct hardware access kernel drivers anymore, sigh.