Re: [PATCH v2 12/16] serial: pic32_uart: update include to use pic32.h from platform_data

[Jiri Slaby]

On 12. 01. 26, 23:48, Brian Masney wrote:
> Use the linux/platform_data/pic32.h include instead of
> asm/mach-pic32/pic32.h so that the asm variant can be dropped. This
> is in preparation for allowing some drivers to be compiled on other
> architectures with COMPILE_TEST enabled.

LGTM. Will you also enable the driver to be compiled?

Reviewed-by: Jiri Slaby <jirislaby@xxxxxxxxxx>

> Signed-off-by: Brian Masney <bmasney@xxxxxxxxxx>
>
> ---
> To: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> To: Jiri Slaby <jirislaby@xxxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Cc: linux-serial@xxxxxxxxxxxxxxx
> ---
>   drivers/tty/serial/pic32_uart.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/pic32_uart.c b/drivers/tty/serial/pic32_uart.c
> index 14d50bd7f1bd3575e60e51783bf5b2d821f9168d..8407f85776c07a7495688fc4f95b8672b1543bd0 100644
> --- a/drivers/tty/serial/pic32_uart.c
> +++ b/drivers/tty/serial/pic32_uart.c
> @@ -22,8 +22,7 @@
>   #include <linux/tty_flip.h>
>   #include <linux/serial_core.h>
>   #include <linux/delay.h>
> -
> -#include <asm/mach-pic32/pic32.h>
> +#include <linux/platform_data/pic32.h>
>   
>   /* UART name and device definitions */
>   #define PIC32_DEV_NAME		"pic32-uart"


--
js
suse labs