RE: [PATCH 2/2] net: axienet: Fix resource release ordering

[Gupta, Suraj]

[AMD Official Use Only - AMD Internal Distribution Only]

> -----Original Message-----
> From: Sean Anderson <sean.anderson@xxxxxxxxx>
> Sent: Monday, January 12, 2026 8:23 PM
> To: Jakub Kicinski <kuba@xxxxxxxxxx>; Gupta, Suraj <Suraj.Gupta2@xxxxxxx>
> Cc: mturquette@xxxxxxxxxxxx; sboyd@xxxxxxxxxx; Pandey, Radhey Shyam
> <radhey.shyam.pandey@xxxxxxx>; andrew+netdev@xxxxxxx;
> davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx; pabeni@xxxxxxxxxx; Simek,
> Michal <michal.simek@xxxxxxx>; linux@xxxxxxxxxxxxxxx; linux-
> clk@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; bmasney@xxxxxxxxxx
> Subject: Re: [PATCH 2/2] net: axienet: Fix resource release ordering
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> On 1/10/26 14:53, Jakub Kicinski wrote:
> > On Fri, 9 Jan 2026 12:40:51 +0530 Suraj Gupta wrote:
> >> Device-managed resources are released after manually-managed resources.
> >> Therefore, once any manually-managed resource is acquired, all
> >> further resources must be manually-managed too.
> >
> > only for resources which have dependencies. Please include in the
> > commit message what exactly is going wrong in this driver. The commit
> > under Fixes seems to be running ioremap, I don't see how that matters
> > vs netdev allocation for example..
>
> In the series I originally submitted this in, I wanted to add a devm resources
> (mdio bus etc.) at the end of probe that required the clocks to be running. But
> as a standalone patch this is more of a cleanup.
>

Thanks Sean, I will modify the commit description accordingly and mention only the conversion to the `devm` version of the clock and netdev allocation APIs.

Regards,
Suraj

> >> Convert all resources before the MDIO bus is created into
> >> device-managed resources. In all cases but one there are already devm
> variants available.