Re: [PATCH] mm: remove redundant page parameter from do_set_pmd()
From: Matthew Wilcox
Date: Mon Jan 12 2026 - 23:09:45 EST
On Tue, Jan 13, 2026 at 09:41:29AM +0800, Ye Liu wrote:
> The page parameter passed to do_set_pmd() was always overwritten with
> &folio->page immediately upon function entry (line 5369 in memory.c),
> making the parameter completely redundant. This confused callers who
> computed different page values only to have them ignored.
No. It's an accident of the implementation that we currently only
support folios up to the size of PMDs. That is not the long-term plan.
We always want to specify exactly which pages of the folio to map.