Re: [PATCH] fixup! genirq: Add interrupt redirection infrastructure

[Radu Rendec]

Hello, Thomas!

On Sun, 2026-01-11 at 22:52 +0100, Thomas Gleixner wrote:
> Thanks for taking care of this, but this is not really the way how it
> works.
> 
> $subject: fixup!.... is neither a valid nor a useful subject line.
> 
> $subject is documented to be a concise summary of the change at hand, so
> in this case this should be something like:
> 
>    [PATCH] genirq: Update effective affinity for redirected interrupts
> 
> [snip]
> 
> It also lacks a 'Fixes:' tag as the code is already merged, no?
> 
> 
> [snip]

Apologies, and thanks a lot for taking the time to provide such
detailed feedback!

I mistakenly assumed the original commit could still be *amended*, and
the format I used was a (failed) attempt at asking that. I didn't
realize the commit was immutable once included in the tip tree, and
didn't pay much attention to the commit message because I thought it
would be discarded anyway while amending.

In my defense, $subject: "fixup! <original commit subject>" is a format
recognized by `git rebase` and used on some subsystems to fix already
accepted patches *before* they are merged upstream. It just doesn't
apply here. Lesson learned!

I will re-send it using the standard format for fixing a commit that's
already merged, and follow all the suggestions you made.

-- 
Best regards,
Radu