Re: [PATCH v3] perf build: Raise minimum shellcheck version to 0.7.2
From: Arnaldo Carvalho de Melo
Date: Mon Jan 12 2026 - 13:54:25 EST
On Thu, Jan 08, 2026 at 12:29:10PM +0100, Nicolas Schier wrote:
> Raise the minimum shellcheck version for perf builds to 0.7.2, so that
> systems with shellcheck versions below 0.7.2 will automatically skip the
> shell script checking, even if NO_SHELLCHECK is unset.
>
> Since commit 241f21be7d0f ("perf test perftool_testsuite: Use absolute
> paths"), shellcheck versions before 0.7.2 break the perf build with
> several SC1090 [2] warnings due to its too strict dynamic source
> handling [1], e.g.:
>
> In tests/shell/base_probe/test_line_semantics.sh line 20:
> . "$DIR_PATH/../common/init.sh"
> ^---------------------------^ SC1090: Can't follow non-constant source. Use a directive to specify location.
>
> Fixes: 241f21be7d0f ("perf test perftool_testsuite: Use absolute paths")
Thanks, applied to perf-tools-next,
- Arnaldo