Re: [PATCH 00/12] HID: Use pm_*ptr instead of #ifdef CONFIG_PM*

[Jiri Kosina]

On Mon, 12 Jan 2026, Benjamin Tissoires wrote:

> > > All those changes should be safe, as similar ones were done in other
> > > subsystems, but I'm uncertain about the surface changes.
> > > 
> > > Bastien Nocera (12):
> > >   HID: hid-alps: Use pm_ptr instead of #ifdef CONFIG_PM
> > >   HID: appletb-kbd: Use pm_ptr instead of #ifdef CONFIG_PM
> > >   HID: asus: Use pm_ptr instead of #ifdef CONFIG_PM
> > >   HID: lenovo: Use pm_ptr instead of #ifdef CONFIG_PM
> > >   HID: logitech-dj: Use pm_ptr instead of #ifdef CONFIG_PM
> > >   HID: nintendo: Use pm_ptr instead of #ifdef CONFIG_PM
> > >   HID: picolcd_core: Use pm_ptr instead of #ifdef CONFIG_PM
> > >   HID: hid-sensor-hub: Use pm_ptr instead of #ifdef CONFIG_PM
> > >   HID: sony: Use pm_ptr instead of #ifdef CONFIG_PM
> > >   HID: uclogic: Use pm_ptr instead of #ifdef CONFIG_PM
> > >   HID: wacom: Use pm_ptr instead of #ifdef CONFIG_PM
> > >   HID: surface: Use pm_ptr_sleep instead of #ifdef CONFIG_PM_SLEEP
> > > 
> > >  drivers/hid/hid-alps.c                     | 6 ++----
> > >  drivers/hid/hid-appletb-kbd.c              | 6 ++----
> > >  drivers/hid/hid-asus.c                     | 6 ++----
> > >  drivers/hid/hid-lenovo.c                   | 4 +---
> > >  drivers/hid/hid-logitech-dj.c              | 4 +---
> > >  drivers/hid/hid-nintendo.c                 | 7 ++-----
> > >  drivers/hid/hid-picolcd_core.c             | 8 +++-----
> > >  drivers/hid/hid-sensor-hub.c               | 8 +++-----
> > >  drivers/hid/hid-sony.c                     | 9 +++------
> > >  drivers/hid/hid-uclogic-core.c             | 6 ++----
> > >  drivers/hid/surface-hid/surface_hid.c      | 2 +-
> > >  drivers/hid/surface-hid/surface_hid_core.c | 5 -----
> > >  drivers/hid/surface-hid/surface_kbd.c      | 2 +-
> > >  drivers/hid/wacom_sys.c                    | 6 ++----
> > >  14 files changed, 25 insertions(+), 54 deletions(-)
> > 
> > Thanks Bastien, this is now in hid.git#for-6.20/pm_ptr.
> > 
> 
> There is something wrong with the series:
> https://gitlab.freedesktop.org/bentiss/hid/-/jobs/90949365

Yeah, and 0day bot found another issue. Dropping for now, this needs more 
polishing apparently :)

-- 
Jiri Kosina
SUSE Labs