Re: [Intel-wired-lan] [PATCH net-next 06/12] dpll: Support dynamic pin index allocation

[Ivan Vecera]

On 1/12/26 4:13 PM, kernel test robot wrote:
> Hi Ivan,
>
> kernel test robot noticed the following build warnings:
>
> [auto build test WARNING on net-next/main]
>
> url:    https://github.com/intel-lab-lkp/linux/commits/Ivan-Vecera/dt-bindings-dpll-add-common-dpll-pin-consumer-schema/20260109-022618
> base:   net-next/main
> patch link:    https://lore.kernel.org/r/20260108182318.20935-7-ivecera%40redhat.com
> patch subject: [Intel-wired-lan] [PATCH net-next 06/12] dpll: Support dynamic pin index allocation
> config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20260112/202601122216.BCarSN6K-lkp@xxxxxxxxx/config)
> compiler: m68k-linux-gcc (GCC) 15.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260112/202601122216.BCarSN6K-lkp@xxxxxxxxx/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@xxxxxxxxx>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202601122216.BCarSN6K-lkp@xxxxxxxxx/
>
> All warnings (new ones prefixed by >>):
>
>     drivers/dpll/dpll_core.c: In function 'dpll_pin_idx_free':
> > > drivers/dpll/dpll_core.c:499:28: warning: integer overflow in expression of type 'int' results in '-2147483648' [-Woverflow]
>       499 |         pin_idx -= INT_MAX + 1;
>           |                            ^
>
>
> vim +499 drivers/dpll/dpll_core.c
>
>     490	
>     491	static void dpll_pin_idx_free(u32 pin_idx)
>     492	{
>     493		if (pin_idx <= INT_MAX)
>     494			return; /* Not a dynamic pin index */
>     495	
>     496		/* Map the index value from dynamic pin index range to IDA range and
>     497		 * free it.
>     498		 */
>   > 499		pin_idx -= INT_MAX + 1;

'pin_idx -= (u32)INT_MAX + 1' should be here..

Will fix.

I.
>     500		ida_free(&dpll_pin_idx_ida, pin_idx);
>     501	}
>     502