Re: [PATCH v5] tracing: Guard __DECLARE_TRACE() use of __DO_TRACE_CALL() with SRCU-fast

From: Peter Zijlstra

Date: Mon Jan 12 2026 - 10:44:15 EST


On Mon, Jan 12, 2026 at 10:36:12AM -0500, Steven Rostedt wrote:
> On Mon, 12 Jan 2026 16:31:28 +0100
> Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
>
> > > OUCH! So migrate disable/enable has a much larger overhead when executed in
> > > a module than in the kernel? This means all spin_locks() in modules
> > > converted to mutexes in PREEMPT_RT are taking this hit!
> >
> > Not so, the migrate_disable() for PREEMPT_RT is still in core code --
> > kernel/locking/spinlock_rt.c is very much not build as a module.
>
> True. But still, wouldn't it be cleaner to have that variable separate from
> the run queue and make the code a bit simpler?

I still don't like exporting variables either way around. Exporting
functions is much saner.