Re: [PATCH v7 3/3] media: qcom: camss: tpg: Add TPG support for multiple targets

[Bryan O'Donoghue]

On 26/12/2025 09:19, Wenmeng Liu wrote:
> Add support for TPG found on LeMans, Monaco, Hamoa.
>
> Signed-off-by: Wenmeng Liu <wenmeng.liu@xxxxxxxxxxxxxxxx>
> ---
>   drivers/media/platform/qcom/camss/Makefile         |   1 +
>   drivers/media/platform/qcom/camss/camss-csid-680.c |  16 ++
>   .../media/platform/qcom/camss/camss-csid-gen3.c    |  16 ++
>   drivers/media/platform/qcom/camss/camss-tpg-gen1.c | 257 +++++++++++++++++++++
>   drivers/media/platform/qcom/camss/camss.c          | 128 ++++++++++
>   5 files changed, 418 insertions(+)
This is causing a regression on Hamoa.

Did you check the camera itself still streams ? For me, camera streaming 
breaks when this patch is applied.

Please look into this.

➞  git bisect good 
 
                [git:60c1b50b1f2f5] ✖
9d1d90cca34ca66617ade951d42c94d5f086717f is the first bad commit
commit 9d1d90cca34ca66617ade951d42c94d5f086717f
Author: Wenmeng Liu <wenmeng.liu@xxxxxxxxxxxxxxxx>
Date:   Fri Dec 26 17:19:12 2025 +0800

    media: qcom: camss: tpg: Add TPG support for multiple targets

    Add support for TPG found on LeMans, Monaco, Hamoa.

    Signed-off-by: Wenmeng Liu <wenmeng.liu@xxxxxxxxxxxxxxxx>
    Signed-off-by: Bryan O'Donoghue <bod@xxxxxxxxxx>

 drivers/media/platform/qcom/camss/Makefile          |   1 +
 drivers/media/platform/qcom/camss/camss-csid-680.c  |  16 ++++++++
 drivers/media/platform/qcom/camss/camss-csid-gen3.c |  16 ++++++++
 drivers/media/platform/qcom/camss/camss-tpg-gen1.c  | 257 
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 drivers/media/platform/qcom/camss/camss.c           | 128 
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 5 files changed, 418 insertions(+)
 create mode 100644 drivers/media/platform/qcom/camss/camss-tpg-gen1.c

➞  git bisect log 
 
                [git:60c1b50b1f2f5] ✖
git bisect start
# status: waiting for both good and bad commits
# bad: [2ae8c3645005e9115f39e8aa61dea9ea48cc356e] media: qcom: camss: 
add support for SM6150 camss

git bisect bad 2ae8c3645005e9115f39e8aa61dea9ea48cc356e
# status: waiting for good commit(s), bad commit known
# good: [f89c11002f67740aaed818137d513d6c3dbc348a] dt-bindings: media: 
qcom,x1e80100-camss: Add missing regs, clocks, iommus

git bisect good f89c11002f67740aaed818137d513d6c3dbc348a
# good: [18f74c5866cb470123eb0b39cf3248a09fab3ef9] media: qcom: camss: 
Add common TPG support

git bisect good 18f74c5866cb470123eb0b39cf3248a09fab3ef9
# bad: [9aaf62e09bb1bb17c186addc49984343623df50e] media: qcom: camss: 
csid-340: Fix unused variables

git bisect bad 9aaf62e09bb1bb17c186addc49984343623df50e
# bad: [9d1d90cca34ca66617ade951d42c94d5f086717f] media: qcom: camss: 
tpg: Add TPG support for multiple targets

git bisect bad 9d1d90cca34ca66617ade951d42c94d5f086717f
# good: [60c1b50b1f2f5466c07aeb4148df25227b5f6d55] media: qcom: camss: 
Add link support for TPG

git bisect good 60c1b50b1f2f5466c07aeb4148df25227b5f6d55
# first bad commit: [9d1d90cca34ca66617ade951d42c94d5f086717f] media: 
qcom: camss: tpg: Add TPG support for multiple targets

---
bod