Re: [PATCH] reset: gpio: suppress bind attributes in sysfs

[Bartosz Golaszewski]

On Thu, Dec 4, 2025 at 10:47 AM Bartosz Golaszewski
<bartosz.golaszewski@xxxxxxxxxxxxxxxx> wrote:
>
> This is a special device that's created dynamically and is supposed to
> stay in memory forever. We also currently don't have a devlink between
> it and the actual reset consumer. Suppress sysfs bind attributes so that
> user-space can't unbind the device because - as of now - it will cause a
> use-after-free splat from any user that puts the reset control handle.
>
> Fixes: cee544a40e44 ("reset: gpio: Add GPIO-based reset controller")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxxxxxxxx>
> ---
>  drivers/reset/reset-gpio.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/reset/reset-gpio.c b/drivers/reset/reset-gpio.c
> index e5512b3b596b..626c4c639c15 100644
> --- a/drivers/reset/reset-gpio.c
> +++ b/drivers/reset/reset-gpio.c
> @@ -111,6 +111,7 @@ static struct auxiliary_driver reset_gpio_driver = {
>         .id_table       = reset_gpio_ids,
>         .driver = {
>                 .name = "reset-gpio",
> +               .suppress_bind_attrs = true,
>         },
>  };
>  module_auxiliary_driver(reset_gpio_driver);
> --
> 2.51.0
>
>

Hi Phillipp!

This is now reviewed by Krzysztof, can you pick it up, please?

Bartosz