Re: [PATCH 3/9] staging: rtl8723bs: simplify boolean expressions

[Dan Carpenter]

On Mon, Jan 12, 2026 at 12:06:24AM +0530, Khushal Chitturi wrote:
>  	do_queue_select(padapter, &pxmitframe->attrib);
>  
>  	spin_lock_bh(&pxmitpriv->lock);
> -	if (xmitframe_enqueue_for_sleeping_sta(padapter, pxmitframe) == true) {
> +	if (xmitframe_enqueue_for_sleeping_sta(padapter, pxmitframe)) {
>  		spin_unlock_bh(&pxmitpriv->lock);
>  		return 1;
>  	}
>  	spin_unlock_bh(&pxmitpriv->lock);
>  
>  	/* pre_xmitframe */
> -	if (rtw_hal_xmit(padapter, pxmitframe) == false)
> +	if (rtw_hal_xmit(padapter, pxmitframe))

You reversed this if statement.  Really, just please throw this patchset
away and restart from scratch.  This wasn't my only complaint about this
patch but the other was more of a style issue and I think you will fix it
if you go slower.

>  		return 1;
>  
>  	return 0;

regards,
dan carpenter