Re: [PATCH 5/9] staging: rtl8723bs: split chained assignments
From: Dan Carpenter
Date: Mon Jan 12 2026 - 03:01:21 EST
On Mon, Jan 12, 2026 at 12:06:26AM +0530, Khushal Chitturi wrote:
> @@ -1155,11 +1158,13 @@ s32 rtw_mgmt_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *pkt, s
> u8 MME[_MME_IE_LENGTH_];
> u32 ori_len;
>
> - mem_start = pframe = (u8 *)(pxmitframe->buf_addr) + TXDESC_OFFSET;
> + mem_start = (u8 *)(pxmitframe->buf_addr) + TXDESC_OFFSET;
> + pframe = (u8 *)(pxmitframe->buf_addr) + TXDESC_OFFSET;
> pwlanhdr = (struct ieee80211_hdr *)pframe;
>
> ori_len = BIP_AAD_SIZE + pattrib->pktlen;
> - tmp_buf = BIP_AAD = rtw_zmalloc(ori_len);
> + tmp_buf = rtw_zmalloc(ori_len);
> + BIP_AAD = rtw_zmalloc(ori_len);
Nope. We don't want two allocations.
regards,
dan carpenter