Re: [PATCH] ASoC: cs4271: Fix resource leak in cs4271_soc_resume()

[Herve Codina]

Hi Harshit,

On Sat, 10 Jan 2026 11:53:36 -0800
Harshit Mogalapalli <harshit.m.mogalapalli@xxxxxxxxxx> wrote:

> Smatch detects this resource leak:
> 
> sound/soc/codecs/cs4271.c:548 cs4271_soc_resume() warn:
>  'cs4271->clk' from clk_prepare_enable() not released on lines: 540,546.
> 
> Instead of direct returns, unprepare the clock and disable regulators on
> the error paths.
> 
> Fixes: cf6bf51b5325 ("ASoC: cs4271: Add support for the external mclk")
> Fixes: 9a397f473657 ("ASoC: cs4271: add regulator consumer support")
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@xxxxxxxxxx>
> ---
> Only compile tested.
> ---
>  sound/soc/codecs/cs4271.c | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
> 

Thanks for the modification.

Acked-by: Herve Codina <herve.codina@xxxxxxxxxxx>

Best regards,
Hervé