Re: [PATCH 2/3] watchdog: atcwdt200: Add driver for Andes ATCWDT200

From: CL Wang

Date: Mon Jan 12 2026 - 02:05:32 EST


Hi Krzysztof,

Thanks for your review.

On 07/01/2026 15:50, Krzysztof Kozlowski wrote:

> Just use API for getting enabled clock.
Agreed. I will switch to using `devm_clk_get_enabled()` to simplify
the clock handling and error paths.

> No, read your binding. You said it is a list... list of phandles?
You are right. The property is intended to be a single uint32
configuration value. I will update the binding schema to clearly
define it as such and make it consistent with the driver.

> Just return.
Agreed. I will simplify the resume path and return directly on error.

> Drop, not needed.
Understood. I will drop the `"andestech,qilai-wdt"` compatible and keep
only the generic one.

> From where did you get this?
You're right, this is unnecessary. I will remove `.owner = THIS_MODULE`.

I will address all of the above in the next revision.

Best regards,
CL Wang