Re: [PATCH v5 3/3] rtc: spacemit: default module when MFD_SPACEMIT_P1 is enabled

[Alex Elder]

On 1/9/26 4:38 PM, Alexandre Belloni wrote:
> On 08/01/2026 16:38:56+0800, Troy Mitchell wrote:
> > The RTC driver defaulted to the same value as MFD_SPACEMIT_P1, which
> > caused it to be built-in automatically whenever the PMIC support was
> > set to y.
> >
> > This is not always desirable, as the RTC function is not required on
> > all platforms using the SpacemiT P1 PMIC.
> >
> > Acked-by: Alex Elder <elder@xxxxxxxxxxxx>
> > Signed-off-by: Troy Mitchell <troy.mitchell@xxxxxxxxxxxxxxxxxx>
> > ---
> > Change log in v5:
> > - add Alex's tag
> > - Link to v4: https://lore.kernel.org/all/20251225-p1-kconfig-fix-v4-3-44b6728117c1@xxxxxxxxxxxxxxxxxx/
>
> See my reply on v4, this is still a NAK for me, I don't believe this
> change is necessary as soon as the default for MFD_SPACEMIT_P1 is m.

Yes I have reconsidered what Alexandre was saying and now I
agree with him, I don't believe this patch is required.

					-Alex

> > ---
> >   drivers/rtc/Kconfig | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
> > index 50dc779f7f983074df7882200c90f0df21d142f2..53866493e9bbaf35ff0de85cbfe43e8343eadc1e 100644
> > --- a/drivers/rtc/Kconfig
> > +++ b/drivers/rtc/Kconfig
> > @@ -410,7 +410,7 @@ config RTC_DRV_SPACEMIT_P1
> >   	tristate "SpacemiT P1 RTC"
> >   	depends on ARCH_SPACEMIT || COMPILE_TEST
> >   	depends on MFD_SPACEMIT_P1
> > -	default MFD_SPACEMIT_P1
> > +	default m if MFD_SPACEMIT_P1
> >   	help
> >   	  Enable support for the RTC function in the SpacemiT P1 PMIC.
> >   	  This driver can also be built as a module, which will be called
> >
> > --
> > 2.52.0