Re: [PATCH] iio: adc: ad7476: Remove duplicate include
From: Jonathan Cameron
Date: Sun Jan 11 2026 - 08:17:07 EST
On Thu, 8 Jan 2026 08:06:13 +0200
Matti Vaittinen <mazziesaccount@xxxxxxxxx> wrote:
> On 07/01/2026 10:29, Chen Ni wrote:
> > Remove duplicate inclusion of linux/bitops.h.
> >
> > Signed-off-by: Chen Ni <nichen@xxxxxxxxxxx>
>
> I would also appreciate having the includes alphabetically ordered as
> Andy suggested. This, however, is a fine fix as it is so:
>
> Reviewed-by: Matti Vaittinen <mazziesaccount@xxxxxxxxx>
Applied this one. As Andy observes in v2 review the first patch
should be this anyway!
Thanks,
Jonathan
>
> > ---
> > drivers/iio/adc/ad7476.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/iio/adc/ad7476.c b/drivers/iio/adc/ad7476.c
> > index 1bec6657394c..21d3f6aae972 100644
> > --- a/drivers/iio/adc/ad7476.c
> > +++ b/drivers/iio/adc/ad7476.c
> > @@ -16,7 +16,6 @@
> > #include <linux/gpio/consumer.h>
> > #include <linux/err.h>
> > #include <linux/module.h>
> > -#include <linux/bitops.h>
> > #include <linux/delay.h>
> >
> > #include <linux/iio/iio.h>
>
>