Re: [PATCH v2 4/6] staging: iio: ad9832: remove dds.h dependency

[Jonathan Cameron]

On Sun, 4 Jan 2026 02:38:50 -0300
Tomas Borquez <tomasborquez13@xxxxxxxxx> wrote:

> On Wed, Dec 31, 2025 at 06:11:53PM +0000, Jonathan Cameron wrote:
> > On Wed, 31 Dec 2025 18:09:39 +0000
> > Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
> >   
> > > On Tue, 30 Dec 2025 17:34:57 -0300
> > > Tomas Borquez <tomasborquez13@xxxxxxxxx> wrote:
> > >   
> > > > Remove dependency on dds.h by converting custom macros to standard IIO
> > > > attribute declarations.
> > > > 
> > > > Signed-off-by: Tomas Borquez <tomasborquez13@xxxxxxxxx>    
> > > Hi Tomas,
> > > 
> > > Happy new year (almost)  
> Hey Jonathan,
> 
> Happy new year!
> 
> ...
> 
> > > I'm not that keen on having the documentation only several patches later. Drag that
> > > before this patch or combine adding the new ABI and documentation in the same patch  
> > Ah. I'd missed that this is deliberately a no change patch with old abi.
> > 
> > So ignore the stuff that doesn't make sense with that in mind!  
> 
> Just to make sure I understood:
> - I should just remove out_altvoltage0_frequency_scale
> - And add documentation in the same patch with all the ABI changes
>   "staging: iio: ad9832: convert to iio channels and ext_info attrs"
>   or as a separate patch like it is now?

It's fine as you have it already.  Ultimately out_altvotage0_frequency_scale
should go away but that can come in the ABI update patch.

I'd just misunderstood that this was simply a 'get rid of dds.h' usage
patch and the real ABI changes are later.

Jonathan

>