Re: [PATCH 2/2] iio: adc: add driver for Texas Instruments TLA2528 adc
From: Jonathan Cameron
Date: Sun Jan 11 2026 - 07:05:05 EST
On Mon, 5 Jan 2026 11:16:39 +0100
Maxime Chevallier <maxime.chevallier@xxxxxxxxxxx> wrote:
> Hi Jonathan,
>
> On 27/12/2025 19:42, Jonathan Cameron wrote:
> > On Tue, 23 Dec 2025 16:55:33 +0100
> > Maxime Chevallier <maxime.chevallier@xxxxxxxxxxx> wrote:
> >
> >> This adds a new driver for the TI TLA2528 ADC chip. It ha 8 12-bit
> >> channels, that can also be configured as 16-bit averaging channels.
> >>
> >> Add a very simple driver for it, allowing reading raw values for each
> >> channel.
> >>
> >> Signed-off-by: Rodolfo Giometti <giometti@xxxxxxxxxxxx>
> >> Signed-off-by: Maxime Chevallier <maxime.chevallier@xxxxxxxxxxx>
> >
> > Hi Maxime,
> >
> > A few extra bits from me
> >
> > Thanks,
> >
> > Jonathan
> >
Hi Maxime,
Small process related request. If you agree with a bit of feedback in a review,
just crop that bit out. Keep the polite response for the change log of the
next version.
Whilst this can feel a little rude, the gain in efficiency and the reduction
in people missing the bits that actually warrant more discussion makes it worthwhile.
2nd time I'm posting this advice today! Lets see how many more times it is
relevant ;)
Jonathan