Re: [PATCH] lib/tests: add KUnit test for bitops

[Ryota Sakamoto]

Hi Yury,

Thank you for your warm welcome and detailed review.

On Sat, Jan 10, 2026 at 11:25 AM Yury Norov <ynorov@xxxxxxxxxx> wrote:
> I'm not a user of kunit, but some people are. And seemingly it would help
> to improve testing coverage through those enabling KUNIT_ALL_TESTS. So I
> don't object against this test.

I'm glad you agree. As you noted, while it is based on the logic from
lib/test_bitops.c, it adapts the test to KUnit framework and fixes the coverage
gap in find_first_bit().

> Can you please resend this patch, and in commit message list all the
> tests from the original lib/test_bitops? Please mention those you move
> to the new test. Is there any new coverage in your version?
>
> Please attach whatever it prints as an output, if any.

Sure, in v2, I will include the list for ported test cases and include
the execution output.

> It's tested at boot only if 'y'. If 'm' - it's not.
> Those 2 paragraphs don't relate to the new test, don't even mention
> it. Please drop them.
> I would add a note that this is a partial copy of test_bitops, and in case
> of _any_ doubt, one could enable config TEST_BITOPS and run the original
> test.

You are right. I will remove the generic KUnit description and add
a reference to the original test.

> Those gentlemen are not even in CC. Are you sure they agree to
> be in this list?

I kept their names to credit the original authors from lib/test_bitops.c. I will
include them in CC for v2.

Regards,
Ryota Sakamoto