Re: [PATCH] iommu/amd: move wait_on_sem() out of spinlock

From: Markus Elfring

Date: Sat Jan 10 2026 - 09:00:28 EST



> +++ b/drivers/iommu/amd/iommu.c

> @@ -3094,13 +3098,18 @@ static void iommu_flush_irt_and_complete(struct amd_iommu *iommu, u16 devid)

> +out_err:
> raw_spin_unlock_irqrestore(&iommu->lock, flags);
> + return;
> }


How do you think about to omit a return statement at the end of the implementation
of such a function with the type “void”?

See also:
https://elixir.bootlin.com/linux/v6.19-rc4/source/scripts/checkpatch.pl#L5612-L5622

Regards,
Markus