Re: [PATCH v4 0/3] rtl8723bs: Remove redundant atomic op and replace global io error var
From: Greg KH
Date: Sat Jan 10 2026 - 03:51:39 EST
On Sat, Jan 10, 2026 at 03:47:39PM +0800, cjz wrote:
> This patch series optimizes the IO error counting logic of the rtl8723bs wireless
> driver by removing redundant atomic_t operations (unnecessary for non-concurrent scenarios) and replacing the global continual_io_error variable with local error counting. The series is split into logical patches (per Greg KH's review comment)
> to ensure each patch fulfills a single, clear purpose, which greatly improves
> reviewability and future maintainability.
>
> Patch Breakdown:
> 1. 0001: Add independent rtw_check_continual_io_error function (single responsibility, includes old function cleanup)
> 2. 0002: Use local error_count in sd_read32/sd_write32 (eliminate global dependency, remove atomic ops)
> 3. 0003: Remove redundant global continual_io_error variable (clean up struct)
>
> Changelog from v3 to v4:
> - Split the monolithic v3 patch into logical, single-purpose patches
> - Fixed all coding style errors (trailing spaces, missing assignment spaces, indentation, blank line alignment)
> - Added detailed, purpose-driven commit messages for each patch
> - Added version changelog as required by kernel documentation
> - Added this cover letter to explain the entire patch series
> - Optimized the new check function to remove redundant ternary expression (more concise kernel style)
>
> Thank you for your time and review!
>
> Signed-off-by: changjunzheng <guagua210311@xxxxxx>
> ---
>
I only see this email, not the 1-3 patches anywhere :(