Re: [RFC PATCH 01/15] static kmem_cache instances for core caches
From: Matthew Wilcox
Date: Sat Jan 10 2026 - 00:40:39 EST
On Sat, Jan 10, 2026 at 04:02:03AM +0000, Al Viro wrote:
> +++ b/Kbuild
> @@ -45,13 +45,24 @@ kernel/sched/rq-offsets.s: $(offsets-file)
> $(rq-offsets-file): kernel/sched/rq-offsets.s FORCE
> $(call filechk,offsets,__RQ_OFFSETS_H__)
>
> +# generate kmem_cache_size.h
> +
> +kmem_cache_size-file := include/generated/kmem_cache_size.h
> +
> +targets += mm/kmem_cache_size.s
> +
> +mm/kmem_cache_size.s: $(rq-offsets-file)
> +
> +$(kmem_cache_size-file): mm/kmem_cache_size.s FORCE
> + $(call filechk,offsets,__KMEM_CACHE_SIZE_H__)
> +
> # Check for missing system calls
>
> quiet_cmd_syscalls = CALL $<
> cmd_syscalls = $(CONFIG_SHELL) $< $(CC) $(c_flags) $(missing_syscalls_flags)
>
> PHONY += missing-syscalls
> -missing-syscalls: scripts/checksyscalls.sh $(rq-offsets-file)
> +missing-syscalls: scripts/checksyscalls.sh $(kmem_cache_size-file)
> $(call cmd,syscalls)
Did you mean to _replace_ rq-offsets-file rather than add
kmem_cache_size-file ?
(I also wonder if we want to just do slab or if we want to make this
mm-offsets.h and maybe put other things in it later, but I'm having
trouble thinking of other things we might want to generate)