Re: [PATCH v17 19/32] x86/resctrl: Find and enable usable telemetry events

From: Borislav Petkov

Date: Fri Jan 09 2026 - 17:02:24 EST


On Fri, Jan 09, 2026 at 08:53:09AM -0800, Luck, Tony wrote:
> This was made a separate function in response to a comment against the
> v9 series from Ilpo:
>
> As this is at least semi-hacky, I suggest you move it into own function
> and add a bit longer comment to the function (along the lines what the
> changelog also states why it works).
>
> Link: https://lore.kernel.org/all/3b0546d4-d0bc-f76e-e1c2-eef2b4abf0f1@xxxxxxxxxxxxxxx/
>
> But at that point the "p->regions[i].addr = NULL;" was part of a much
> larger function. Since then refactoring into various helpers means that
> it now looks OK to move it inline. The comment about why it is safe to
> update a structure that was provided by Intel-PMT driver is the
> important bit, and I see that you preserved that.
>
> So LGTM

Thank you both!

/me folds in.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette