Re: [PATCH bpf-next v1 03/10] bpf: Verifier support for KF_IMPLICIT_ARGS

From: Alexei Starovoitov

Date: Fri Jan 09 2026 - 14:55:05 EST


On Fri, Jan 9, 2026 at 10:49 AM Ihor Solodrai <ihor.solodrai@xxxxxxxxx> wrote:
>
> + if (unlikely(kfunc_flags && KF_IMPLICIT_ARGS & *kfunc_flags))

Please add extra () around &

that's the style we use elsewhere. Like:
if (!first && (env->log.level & BPF_LOG_LEVEL2))

> + if (unlikely(KF_IMPLICIT_ARGS & meta.kfunc_flags
> + && is_kfunc_arg_implicit(desc_btf, &args[i])))

same

pw-bot: cr