Re: [PATCH 10/13] watchdog: pic32-dmt: update include to use pic32.h from platform_data
From: Guenter Roeck
Date: Fri Jan 09 2026 - 12:08:40 EST
On Fri, Jan 09, 2026 at 11:41:23AM -0500, Brian Masney wrote:
> Use the linux/platform_data/pic32.h include instead of
> asm/mach-pic32/pic32.h so that the asm variant can be dropped. This
> is in preparation for allowing some drivers to be compiled on other
> architectures with COMPILE_TEST enabled.
>
> Signed-off-by: Brian Masney <bmasney@xxxxxxxxxx>
>
linux/platform_data/pic32.h doesn't exist upstream, and I was not
copied on the patch introducing it, so I'll just blindly asume that
this works.
Acked-by: Guenter Roeck <linux@xxxxxxxxxxxx>
Guenter
> ---
> To: Wim Van Sebroeck <wim@xxxxxxxxxxxxxxxxxx>
> To: Guenter Roeck <linux@xxxxxxxxxxxx>
> Cc: linux-watchdog@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> ---
> drivers/watchdog/pic32-dmt.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/watchdog/pic32-dmt.c b/drivers/watchdog/pic32-dmt.c
> index ab0682492c85ad63160bb7da61cc74336698a4e9..12e3a8f63589862e3ed674ffb71ee4798755e56f 100644
> --- a/drivers/watchdog/pic32-dmt.c
> +++ b/drivers/watchdog/pic32-dmt.c
> @@ -12,12 +12,11 @@
> #include <linux/kernel.h>
> #include <linux/module.h>
> #include <linux/of.h>
> +#include <linux/platform_data/pic32.h>
> #include <linux/platform_device.h>
> #include <linux/pm.h>
> #include <linux/watchdog.h>
>
> -#include <asm/mach-pic32/pic32.h>
> -
> /* Deadman Timer Regs */
> #define DMTCON_REG 0x00
> #define DMTPRECLR_REG 0x10
>
> --
> 2.52.0
>
>