Re: [PATCH] of: guard pointers to key OF nodes with an #ifdef
From: Rob Herring
Date: Thu Jan 15 2026 - 22:21:46 EST
On Thu, Jan 15, 2026 at 2:21 PM Rob Herring (Arm) <robh@xxxxxxxxxx> wrote:
>
>
> On Thu, 15 Jan 2026 10:18:39 +0100, Bartosz Golaszewski wrote:
> > We declare the pointers to some key OF-nodes unconditionally in
> > linux/of.h but only export them with CONFIG_OF=y. If anyone uses them in
> > code built without devicetree support enabled, the problem will only come
> > to light at link-time. Add an #ifdef guard to catch it at compile-time.
> >
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxxxxxxxx>
> > ---
> > include/linux/of.h | 2 ++
> > 1 file changed, 2 insertions(+)
> >
>
> Applied, thanks!
Err, and dropped.
BTW, my ideal fix for this is to eliminate any users of these variables.
Rob