Re: [PATCH][next] drm/amd/pm: Avoid multiple -Wflex-array-member-not-at-end warnings

[Alex Deucher]

On Thu, Jan 15, 2026 at 7:14 PM Kees Cook <kees@xxxxxxxxxx> wrote:
>
> On Wed, Aug 13, 2025 at 08:57:58AM -0400, Alex Deucher wrote:
> > On Wed, Aug 13, 2025 at 1:12 AM Gustavo A. R. Silva
> > <gustavo@xxxxxxxxxxxxxx> wrote:
> > >
> > > Hi!
> > >
> > > On 22/04/25 23:58, Gustavo A. R. Silva wrote:
> > > >
> > > >
> > > > On 16/04/25 09:04, Alex Deucher wrote:
> > > >> Can you resend, I can't seem to find the original emails.
> > > >> Additionally, all of the NISLANDS structures are unused in amdgpu, so
> > > >> those could be removed.
> > >
> > > I'm taking a look at this, and it seems that those NISLANDS structs are actually
> > > needed in amdgpu code. For instance, `struct si_power_info` contains a member
> > > of the type of `struct ni_power_info`, and this latter struct contains a
> > > member of the type of `NISLANDS_SMC_STATETABLE`, thus `NISLANDS_SMC_SWSTATE`
> > > and `NISLANDS_SMC_HW_PERFORMANCE_LEVEL` are needed, and so on.
> > >
> > > So, it seems that all those structs should stay. What do you think?
> >
> > They are not used for programming the hardware.  They were just
> > inherited from radeon.  All of the NI SMC stuff can be dropped.
>
> (Looking through patchwork...)
>
> It's not obvious for me how to drop that stuff. It seems pretty
> integral? What's wanted here?

All of the NI stuff has been removed.  You can rebase your patch.

Alex