Re: [PATCH 2/2] zram: fixup read_block_state()
From: Andrew Morton
Date: Thu Jan 15 2026 - 18:25:54 EST
On Fri, 16 Jan 2026 07:54:25 +0900 Sergey Senozhatsky <senozhatsky@xxxxxxxxxxxx> wrote:
> On (26/01/15 14:07), Andrew Morton wrote:
> > On Thu, 15 Jan 2026 12:30:06 +0900 Sergey Senozhatsky <senozhatsky@xxxxxxxxxxxx> wrote:
> >
> > > ac_time is now in seconds, do not use ktime_to_timespec64()
> >
> > Please help me out here - which patch introduced the issue which Chris
> > found?
>
> This one:
> https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/zram-use-u32-for-entry-ac_time-tracking.patch
I figured that out when I fouf Chris's email ;)
> > > Reported-by: Chris Mason <clm@xxxxxxxx>
> >
> > The Closes: link would be helpful.
>
> I thought that for fixup patches that are still in your tree we
> don't need Closes: tags. If you prefer to have them, it should
> be this email:
> http://lore.kernel.org/linux-kernel/20260114124522.1326519-1-clm@xxxxxxxx
Yep, got it thanks.
Closes: tags are helpful when reviewing, to see all the info. Fixes:
tags aren't useful because the hashes are unstable and because the fix
is destined to become part of the thing which it fixes anyway.