Re: [PATCH v2 15/35] lib/crypto: s390/aes: Migrate optimized code into library

From: Holger Dengler

Date: Thu Jan 15 2026 - 17:00:28 EST


On 12/01/2026 20:20, Eric Biggers wrote:
> Implement aes_preparekey_arch(), aes_encrypt_arch(), and
> aes_decrypt_arch() using the CPACF AES instructions.
>
> Then, remove the superseded "aes-s390" crypto_cipher.
>
> The result is that both the AES library and crypto_cipher APIs use the
> CPACF AES instructions, whereas previously only crypto_cipher did (and
> it wasn't enabled by default, which this commit fixes as well).
>
> Note that this preserves the optimization where the AES key is stored in
> raw form rather than expanded form. CPACF just takes the raw key.
>
> Acked-by: Ard Biesheuvel <ardb@xxxxxxxxxx>
> Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx>

Thanks!

Tested-by: Holger Dengler <dengler@xxxxxxxxxxxxx>
Reviewed-by: Holger Dengler <dengler@xxxxxxxxxxxxx>

--
Mit freundlichen Grüßen / Kind regards
Holger Dengler
--
IBM Systems, Linux on IBM Z Development
dengler@xxxxxxxxxxxxx